-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
Hey @barry-jin , Thanks for submitting the PR
CI supported jobs: [clang, miscellaneous, unix-cpu, website, centos-gpu, edge, unix-gpu, windows-cpu, centos-cpu, windows-gpu, sanity] Note: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add a test case that catches the bug
I have updated Test Logs
Segmentation Fault can be reproduced as follows
|
python/mxnet/numpy/fallback.py
Outdated
"""Get new numpy function with object and doc""" | ||
def fn(*args, **kwargs): | ||
return obj(*args, **kwargs) | ||
fn.__doc__ = doc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can use functools.wraps
Description
Workaround for #19454 to make mxnet numpy operators fall back to the correct official numpy function.
Checklist
Essentials
Changes
get_func
to get official numpy functionComments